perf: Cache common callbacks with a single state parameter #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Wraith2 Thanks! |
Wraith2
force-pushed
the
perf-readasynccachecallback
branch
from
d12e570
to
3adf6ed
Compare
|
Done, only on AE test is failing and I've been nowhere near it. |
cheenamalhotra
added
the
📈 Performance
cheenamalhotra
approved these changes
Feb 6, 2020
panoskj
added a commit
to panoskj/SqlClient
that referenced
this pull request
Aug 26, 2022
panoskj
added a commit
to panoskj/SqlClient
that referenced
this pull request
Nov 21, 2022
panoskj
added a commit
to panoskj/SqlClient
that referenced
this pull request
Nov 21, 2022
panoskj
added a commit
to panoskj/SqlClient
that referenced
this pull request
Nov 21, 2022
panoskj
added a commit
to panoskj/SqlClient
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple of common paths when reading data there are async context captures generated which use a single variable from the enclosing scope. These can be optimized so that a static delegate to the implementation is stored and the variable passed as state, this removes the closure allocation.