Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SqlSequentialStream multipacket reads stalling and add covering test #603

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Jun 14, 2020

Fixes #600

When I reworked async infrastructure a couple of subtle errors crept in and because there was no covering test weren't visible. This corrects the problem and adds a test.

@cheenamalhotra @David-Engel I'd suggest that this go into 2.0.0 release.

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Jun 15, 2020

Hi @Wraith2

This looks like a workaround but not the real issue fix.
The same code exists in NetFx project but does not cause any problems.

We should investigate when this issue was introduced in NetCore and fix the real problem when it was introduced.

@Wraith2
Copy link
Contributor Author

Wraith2 commented Jun 15, 2020

The async changes I've made aren't in the fx codebase and they are what will have introduced the issue so I'm not surprised that it isn't reproducible on fx.

It is intended to be the correct fix and not a workaround though. I debugged through for a quite a while and I was satisfied that there wasn't a huge underlying problem but that it was due to the changes from async captures to using a state object.

@Wraith2
Copy link
Contributor Author

Wraith2 commented Jun 15, 2020

It'll have been introduced in #328

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cheenamalhotra cheenamalhotra added this to the 2.0.0 milestone Jun 15, 2020
@cheenamalhotra
Copy link
Member

We'll take it in for GA.

@cheenamalhotra cheenamalhotra merged commit fc6aece into dotnet:master Jun 15, 2020
@Wraith2
Copy link
Contributor Author

Wraith2 commented Jun 15, 2020

Excellent thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Async SequentialStream reads do not complete
3 participants