-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Add "Command Timeout" connection string property #722
Conversation
Hi @ErikEJ Yes, that's correct. Basically the XML files contain 1:1 documentation of all public APIs in the driver in order to use them in both NetFx and NetCore source to reduce duplication. |
@cheenamalhotra This is ready for review now 😄 |
Thanks for getting this in, a very useful new feature imho. |
This allow the default CommandTimeout of 30 seconds to be overridden, without any code changes.
fixes #614
QUESTION re missing docs:
I am not familiar with the way XML docs are created here, should I add something similar to this:
https://github.com/dotnet/SqlClient/blob/master/doc/snippets/Microsoft.Data.SqlClient/SqlCommand.xml#L1217
in the SqlConnection.xml and SqlConnectionString.xml files?