Tests | Addressing string.Format parametes issue in test lab #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
requested review from
cheenamalhotra,
johnnypham,
karinazhou and
DavoudEshtehari
added 2 commits
January 13, 2021 11:32
cheenamalhotra
added
the
Area\Tests
cheenamalhotra
changed the title
cheenamalhotra
approved these changes
Jan 13, 2021
karinazhou
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in .net5 test lab, I noticed .net5 runtime has captured some unobserved issues in our test labs.
DataTestUtilityclass at line 357 uses string.Format with 3 variables placeholder, but we are passing 4 items to it.Also in SqlRandmizer at line 663 same issue happens. This PR is to address that urgently other fixes come after in separate PR.