-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdamW bug on v0.96.0 #516
Comments
@QingtaoLi1 -- the renaming and the type change should not affect anything. Down in native code, neither matters. Could you provide the whole stack trace? The one line you have is not enough to give me an idea of what is going on. |
Also, in the next release, AdamW will be implemented in managed code, so things are likely to change. |
Stack trace here. It points to the constructor of Adam and nothing else. The only error message is "external component..." I showed above. |
Okay, thanks! |
@NiklasGustafsson Oh I didn't notice I was captioning the error of |
Let's see how this changes with the new implementation in 0.96.1 |
Great! P.S. I tried |
Hmmm. There's something fundamentally wrong. Is there any possibility of any mixup of DLLs or packages? |
I'm not sure. Just try deleting |
OK. Can you try running some of the examples in dotnet/TorchSharpExamples? |
@NiklasGustafsson Weird, TorchSharpExamples for AG_NEWS and MNIST can run. I don't find anything different between my code and the examples -- getting parameters by |
If you have a chance to narrow it down to a smaller example, running with random data, etc., that would be great. Maybe it has something to do with the specific modules you are using? |
When I update TorchSharp from 0.95.4 to 0.96.0, some exception occurs on
torch.optim.AdamW()
:The only change I commit is lower-casing
train()
andeval()
. Notice that the first argument oftorch.optim.AdamW()
(and other optimizers) changes fromIEnumerable<torch.Tensor>
toIEnumerable<TorchSharp.Modules.Parameter>
, so I guess the bug is related to library changes to solve #501.The text was updated successfully, but these errors were encountered: