Fixed double-counting of parameters when a module is referenced in more than one way. #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
reviewed
Feb 23, 2022
Comment on lines
474
to
477
| foreach (var (n, p) in sm.named_parameters(true)) { | ||
| if (seen.Contains(p.Handle)) continue; | ||
| seen.Add(p.Handle); | ||
| yield return ($"{name}.{n}", p); |
There was a problem hiding this comment.
seen should be passed recursively
There was a problem hiding this comment.
I guess that would be more efficient, but it shouldn't affect the result. I'll have to create a non-public member for it.
There was a problem hiding this comment.
You are right, I did not notice it was not actually a counting function, but a parameter enumerator.
There was a problem hiding this comment.
It's still a good idea to pass it down for efficiency.
lostmsu
approved these changes
Feb 23, 2022
|
@Metritutus -- thanks for the issue, it allowed me to find and fix a significant error in the implementation of Module.parameters()! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.