-
Notifications
You must be signed in to change notification settings - Fork 528
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Xamarin.Android.Build.Tasks] Improve AAPT error granularity (#3577)
Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/735263 Context: https://android.googlesource.com/platform/frameworks/base/+/563abce4ed0a0d9f08f8839a8f15b548b3dcd4d1/tools/aapt Context: https://gist.github.com/grendello/72c1ce5f6e8cdd3aefd393b983576d9a Errors and warning *codes* for errors and warnings reported *within Visual Studio* from developers participating in the [Visual Studio Customer Experience Improvement Program][0] are reported "telemetry" events, but *only* the error and warning codes are reported. The warning and error message contents are not sent. Unfortunately all `aapt`-related errors are reported as APT0000, which reduces the utility of telemetry, making it more difficult to better understand where our build system could be improved. @grendello created a `grep` pipeline for the `aapt` sources to try to extract plausible error messages that we can compare against. The exact pipeline has been lost, but this is an in-progress pipeline for finding error messages from the `aapt2` sources: rgrep -Pzoh '(?s)(->|\.)Error.*?;\n' * | \ tr -d '\n' | tr ';' '\n'| \ sed -e 's/^[ \t]*//g' -e 's/^.*Error([ \t]*DiagMessage[ \t]*(.*)[ \t]*<<//g' -e 's/^.*Error(.*)//g;' -e 's/^;$//g' | \ sort | uniq Improve the `<Aapt/>` task to check against this list of "known" error strings and associate them with unique `APTxxxx` codes. This will allow for more meaningful documentation to be written in the future, and will allow our telemetry to be more meaningful and permit improved focusing of future efforts. [0]: https://docs.microsoft.com/en-us/visualstudio/ide/visual-studio-experience-improvement-program?view=vs-2019
- Loading branch information
Showing
3 changed files
with
173 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters