Skip to content

Commit

Permalink
[build] set $(AllowSelfContainedWithoutRuntimeIdentifier) (#8547)
Browse files Browse the repository at this point in the history
Context: #8366
Context: dotnet/sdk@d21e6bf

Rolf introduced an "escape hatch" in the .NET 9 SDK for emitting a build
warning for a case that doesn't make sense on mobile. All mobile apps
are self-contained, and we define RIDs by default, so the error is not
needed.

It appears than when building `net8.0-android` apps on the .NET 9 SDK,
we will also need to silence this warning. This property should not have
any effect in the stable, .NET 8 SDK.

After this change goes in, we'll likely need the .NET 9 Android workload
to depend on a newer .NET 8 Android workload with this change in place.
  • Loading branch information
jonathanpeppers authored Dec 1, 2023
1 parent b39aed0 commit d12da3a
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<AndroidUseDesignerAssembly Condition=" '$(AndroidUseDesignerAssembly)' == '' ">true</AndroidUseDesignerAssembly>
<AndroidUseIntermediateDesignerFile Condition=" '$(AndroidUseDesignerAssembly)' == 'True' ">false</AndroidUseIntermediateDesignerFile>
<AndroidUseIntermediateDesignerFile Condition=" '$(AndroidUseIntermediateDesignerFile)' == '' ">$(AndroidGenerateResourceDesigner)</AndroidUseIntermediateDesignerFile>
<AllowSelfContainedWithoutRuntimeIdentifier Condition =" '$(AllowSelfContainedWithoutRuntimeIdentifier)' == '' ">true</AllowSelfContainedWithoutRuntimeIdentifier>
<GenerateDependencyFile Condition=" '$(GenerateDependencyFile)' == '' ">false</GenerateDependencyFile>
<CopyLocalLockFileAssemblies Condition=" '$(CopyLocalLockFileAssemblies)' == '' ">false</CopyLocalLockFileAssemblies>
<ComputeNETCoreBuildOutputFiles Condition=" '$(ComputeNETCoreBuildOutputFiles)' == '' ">false</ComputeNETCoreBuildOutputFiles>
Expand Down

0 comments on commit d12da3a

Please sign in to comment.