Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to xamarin/Java.Interop/master@807ed48 #3484

Closed
wants to merge 1 commit into from

Conversation

steveisok
Copy link
Member

No description provided.

@jonpryor
Copy link
Member

This doesn't build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2935494&view=logs&jobId=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e

Java.Interop.Tools.Cecil/MethodDefinitionRocks.cs(113,13): error CS1061: 'TypeReference' does not contain a definition for 'ConstraintType' and no accessible extension method 'ConstraintType' accepting a first argument of type 'TypeReference' could be found (are you missing a using directive or an assembly reference?)

That's because of this commit: dotnet/java-interop@807ed48

Which bumps to an API-incompatible version of Cecil. dotnet/java-interop@807ed482 can only be used with PR #3449, and thus should be applied to a xamarin/java.interop/mono-2019-08 branch.

Closing this PR. For now, master & the xamarin-android/mono-2019-08 need to refer to seperate Java.Interop branches.

@jonpryor
Copy link
Member

Nominally superseded by PR #3504.

@jonpryor jonpryor closed this Aug 15, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants