[net6] Bump DotNetPreview version to 6.0.100-preview.1.21109.8 #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing on CI, looks like illink lost some steps. |
radekdoulik
force-pushed
the
pr-bump-net6-preview.1.21109.8
branch
from
d436b59
to
24a48bf
Compare
The linker doesn't load all assemblies anymore. We depend on processing of all assemblies before `MarkStep`. Use reflection as temporary workaround to overcome that, until we have new API in the linker available to handle our processing as part of `MarkStep`.
This also gets rid of typo in previous commit, which caused problems in XF test.
radekdoulik
force-pushed
the
pr-bump-net6-preview.1.21109.8
branch
from
24a48bf
to
add54f8
Compare
We need at least use the enumerable
radekdoulik
changed the title
radekdoulik
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
dellis1972
reviewed
Feb 25, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@radekdoulik maybe we should use the same version as macios: |
|
I would like to finish it with |
dellis1972
approved these changes
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
DotNetPreviewversion to6.0.100-preview.1.21109.8Add linker reflection based workaround, till
the new API is ready to use.
It forces the
ILLinkto process all the referenced assemblies in our steps,without it, no assemblies are processed before
MarkStep.Updated apk size reference files. The NET6 linker has more optimizations
enabled, assembly sizes decreased about 0.5% and native shared libraries
are smaller as well - about 0.7%.
Comparison of
BuildReleaseArm64apk test sizes before/after