[trimming] remove $(_AggressiveAttributeTrimming) by default
#9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#9060 This was introduced in 60e983c (.NET 6 timeframe). It is a "private" switch that is no longer recommended.
jonathanpeppers
commented
Jun 28, 2024
| "PackageSize": 2693653 | ||
| "PackageSize": 2714133 |
There was a problem hiding this comment.
It looks like a Xamarin.Forms (legacy) app is about 77kb bigger and hello world android 20kb bigger.
That seems reasonable if there is concern of something breaking from this setting.
dellis1972
approved these changes
Jun 28, 2024
sbomer
reviewed
Jun 28, 2024
| @@ -116,7 +116,6 @@ | |||
| <StartupHookSupport Condition="'$(StartupHookSupport)' == ''">false</StartupHookSupport> | |||
| <UseNativeHttpHandler Condition=" $(AndroidHttpClientHandlerType.Contains ('System.Net.Http.SocketsHttpHandler')) And '$(UseNativeHttpHandler)' == '' ">false</UseNativeHttpHandler> | |||
| <UseNativeHttpHandler Condition="'$(UseNativeHttpHandler)' == ''">true</UseNativeHttpHandler> | |||
| <_AggressiveAttributeTrimming Condition="'$(_AggressiveAttributeTrimming)' == ''">true</_AggressiveAttributeTrimming> | |||
| <NullabilityInfoContextSupport Condition="'$(NullabilityInfoContextSupport)' == ''">false</NullabilityInfoContextSupport> | |||
There was a problem hiding this comment.
@jonathanpeppers note that NullabilityInfoContextSupport was removed in dotnet/runtime#103970.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 1, 2024
Context: dotnet/runtime#103970 Context: dotnet#9062 (comment) This setting was removed in dotnet/runtime#103970, so it doesn't do anything.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 1, 2024
Context: dotnet/runtime#103970 Context: dotnet#9062 (comment) This setting was removed in dotnet/runtime#103970, so it doesn't do anything.
jonpryor
pushed a commit
that referenced
this pull request
Jul 2, 2024
Context: dotnet/runtime#103970 Context: #9062 (comment) This setting was removed in dotnet/runtime#103970, so it doesn't do anything.
grendello
added a commit
that referenced
this pull request
Jul 5, 2024
* main: [tests] verify trimmer warnings where appropriate (#9076) Bump to jbevain/cecil@8c123e1 (#9078) [trimming] remove `$(NullabilityInfoContextSupport)` (#9069) [build] Bump `$(XABuildToolsVersion)`=35 (#9071) [ci] Move PR build to shared pool (#8854) Use AsyncTask from xamarin-android-tools (#9017) Bump to dotnet/sdk@02c06d398a 9.0.100-preview.7.24351.1 (#9067) [trimming] use public `$(MetricsSupport)` property (#9068) [ci] Update resourceManagement.yml (#9070) Bump to dotnet/android-api-docs@c14203771a (#8992) [trimming] remove `$(_AggressiveAttributeTrimming)` by default (#9062)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9060
This was introduced in 60e983c (.NET 6 timeframe).
It is a "private" switch that is no longer recommended.