Skip to content

Commit

Permalink
Remove old Microsoft.DotNet.Build.Tasks.SharedFramework sdk now that …
Browse files Browse the repository at this point in the history
…it is unused. (#6809)
  • Loading branch information
jkoritzinsky authored Jan 15, 2021
1 parent 86fde30 commit 99968bd
Show file tree
Hide file tree
Showing 57 changed files with 2 additions and 5,555 deletions.
2 changes: 0 additions & 2 deletions Arcade.sln
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.NuGetRepac
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.Build.Tasks.Feed.Tests", "src\Microsoft.DotNet.Build.Tasks.Feed.Tests\Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj", "{6E19C6B6-4ADF-4DD6-86CC-6C1624BCDB71}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk", "src\Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk\Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk.csproj", "{62B929C4-3D15-4D43-AEFC-2D0BD3CFC20D}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.Helix.JobSender.Tests", "src\Microsoft.DotNet.Helix\JobSender.Tests\Microsoft.DotNet.Helix.JobSender.Tests.csproj", "{3376C769-211F-4537-A156-5F841FF7840B}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.CMake.Sdk", "src\Microsoft.DotNet.CMake.Sdk\Microsoft.DotNet.CMake.Sdk.csproj", "{B1BFCB54-0FE7-4745-A471-2D7F21B5C7B9}"
Expand Down
2 changes: 1 addition & 1 deletion Documentation/CorePackages/PostBuildSigning.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

In publishing v3, signing will be moved out of the build step and will be completed post-build in a release pipeline. This reduces the time required for builds that do not require signing and allows repos to have more control over when the signing process occurs.

Any repositories that wish to move to post-build signing should ensure that they're using v3 publishing, including Publish.proj. Repositories that produce wix installers (msi's, wixlabs, etc) are additionally required to use Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk and ensure that ItemsToSign in the AssetManifest includes the generated *wixpack.zip files generated by the SDK.
Any repositories that wish to move to post-build signing should ensure that they're using v3 publishing, including Publish.proj. Repositories that produce wix installers (msi's, wixlabs, etc) are additionally required to use Microsoft.DotNet.Build.Tasks.Installers targets and ensure that ItemsToSign in the AssetManifest includes the generated *wixpack.zip files generated by the SDK.
If PostBuildSign==true then no other steps are needed, post-build signing is enabled and configured by default.

Steps to ensure that post-build signing is correctly set up for a repo: A manifest file is created as part of the build process, it can be found in AssetManifests/Manifest.xml. This file lists everything that will be signed once the build is complete. If this file has been created and the contents of the ItemsToSign section match the expected set of signed files for the build then no further action is needed.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.Build.Tasks.Installers/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ The purpose of the wix command package is to provide a simple way to operate on

### Producing Wix Command packages

If you're using the [Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk](https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk) package or the targets in this package to produce wix artifacts, then a wix command package will automatically be created for you. If you're using the [wix toolset](https://wixtoolset.org/) to produce wix files, then you can produce "wix command packages" using the MSBuild tasks directly.
If you're using the targets in this package to produce wix artifacts, then a wix command package will automatically be created for you. If you're using the [wix toolset](https://wixtoolset.org/) to produce wix files, then you can produce "wix command packages" using the MSBuild tasks directly.

Wix command packages are produced by using the `CreateLightCommandPackageDrop` or `CreateLitCommandPackageDrop` MSBuild tasks from the `Microsoft.DotNet.Build.Tasks.Installers` package. Task usage is defined [here](https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.Installers/README.md#tasks)

Expand Down

This file was deleted.

29 changes: 0 additions & 29 deletions src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/README.md

This file was deleted.

26 changes: 0 additions & 26 deletions src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/sdk/Sdk.props

This file was deleted.

This file was deleted.

Loading

0 comments on commit 99968bd

Please sign in to comment.