Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send-to-helix.yml should support specifying the project path as a template parameter #14470

Closed
2 tasks
radical opened this issue Feb 9, 2024 · 1 comment · Fixed by #14473
Closed
2 tasks

send-to-helix.yml should support specifying the project path as a template parameter #14470

radical opened this issue Feb 9, 2024 · 1 comment · Fixed by #14473

Comments

@radical
Copy link
Member

radical commented Feb 9, 2024

  • This issue is blocking
  • This issue is causing unreasonable pain

IIUC, the files in eng/common are meant to be used as-is instead of making modifications to them. For the non-trivial helix case the eng/common/helixpublish.proj is not enough, and a custom project file has to be created (https://github.com/dotnet/arcade/blob/main/Documentation/AzureDevOps/SendingJobsToHelix.md#the-more-complex-case) . But the eng/common/templates/steps/send-to-helix.yml has the project file path and arguments fixed in the template, which would mean making a copy of the template and modifying that.

What is the recommended way of doing this? If the template can accept parameters for project path, and extra arguments to be passed to the build, then the template can be used as-is with a custom project file.

This was hit in dotnet/aspire#1917 .

cc @joperezr @eerhardt
@radical radical mentioned this issue Feb 9, 2024
Merged
@akoeplinger
Copy link
Member

adding the parameters sounds good to me, mind opening a PR?

@radical radical mentioned this issue Feb 9, 2024
Merged
radical added a commit to radical/arcade that referenced this issue Feb 9, 2024
@radical
send-to-helix.yml: Introduce parameters for project path, and arguments
eac709e 
This allows using the template unchanged from
`eng/common/templates/steps/send-to-helix.yml` with a custom project
file for helix.

Fixes dotnet#14470 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

send-to-helix.yml: Introduce parameters for project path, and arguments radical/arcade
2 participants
@radical @akoeplinger