Remove bash dependency from init-compiler #11359
Conversation
am11
force-pushed
the
feature/shell-scripts
branch
from
3f961a2
to
14453e9
Compare
am11
force-pushed
the
feature/shell-scripts
branch
from
14453e9
to
5ad6cc5
Compare
| compiler=gcc | ||
| ;; | ||
| esac | ||
|
|
||
| cxxCompiler="$compiler++" | ||
|
|
||
| . "$nativescriptroot"/../pipeline-logging-functions.sh |
There was a problem hiding this comment.
@dotnet/roslyn-infrastructure This is deleting eng system telemetry. Why was this telemetry added in the first place? Are we ok with deleting it?
There was a problem hiding this comment.
I think it was added to satisfy validation in eng/configure-toolset.sh, that has an ignore list which I have updated below.
Note that when we invoke build.sh in runtime and diagnostics repos, which call multiple scripts before reaching init-compiler.sh, we use plain echo or print commands in all those scripts. This script only has a few error cases, which we don't encounter in the CI, so I replaced Write-PipelineTelemetryError with echo.
There was a problem hiding this comment.
We do not encounter these error cases in the CI when everything is working correctly. We may encounter these error cases in the CI on infrastructure updates or when things break for some reason. IIRC, it is why this telemetry was added in the first place - to allow eng system team to see that there is a problem in some repo after the update.
There was a problem hiding this comment.
When it was added, this script was only used by arcade cmake SDK. I deduplicated that code in dotnet/runtime#59018 just to avoid duplication and not for telemetry. The one invovled in the build had no stake in telemetry data. I don't think out of all the other possible errors in 20+ scripts involved in the build (which use echo), there is anything special about the few in this script.
No description provided.