Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra logging to DownloadFile after all retries fail #14147

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add extra logging to DownloadFile after all retries fail #14147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ private async Tasks.Task<bool> DownloadWithRetriesAsync(HttpClient httpClient, s
}

Log.LogMessage($"Retrying download of '{uri}' to '{DestinationPath}' due to failure: '{e.Message}' ({attempt}/{Retries})");
Log.LogErrorFromException(e, true, true, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that log the inner exception as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so https://learn.microsoft.com/en-us/dotnet/api/microsoft.build.utilities.tasklogginghelper.logerrorfromexception?view=msbuild-17-netcore#microsoft-build-utilities-tasklogginghelper-logerrorfromexception(system-exception-system-boolean-system-boolean-system-string)


await Tasks.Task.Delay(RetryDelayMilliseconds).ConfigureAwait(false);
continue;
Expand Down
Loading