Delete the deprecated APICompat tooling from Arcade #14328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APICompat got re-implemented on top of Microsoft.CodeAnalysis and lives in dotnet/sdk. It also became a shipping product with .NET 6. The source code was kept around for some time so that consumers could move to the new tooling. Now seems the right time to finally delete the code-base. This tool was already excluded in source build so the deletion won't result in a build break. If there are still some repos that depend on the live version of APICompat v1, they will just not get a new dependency update for it. The code base has been frozen anyway so consumers shouldn't be impacted by this.
akoeplinger
approved these changes
Jan 4, 2024
| @@ -6,7 +6,7 @@ | |||
| <PropertyGroup Condition="'$(GeneratePlatformNotSupportedAssemblyMessage)' != ''"> | |||
| <CoreCompileDependsOn>AddGenFacadeNotSupportedCompileItem;$(CoreCompileDependsOn)</CoreCompileDependsOn> | |||
| <!-- Not supported sources are created from the ref assembly, we currently don't produce finalizers in dummy assemblies, so we disable ApiCompat to not fail. --> | |||
| <RunApiCompat>false</RunApiCompat> | |||
| <ApiCompatValidateAssemblies Condition="'$(IsCrossTargetingBuild)' != 'true'">false</ApiCompatValidateAssemblies > | |||
There was a problem hiding this comment.
why do we need the condition?
There was a problem hiding this comment.
This comes from here: https://github.com/dotnet/runtime/blob/baeb2983ca526d3bfcda091000ecd8e48dc3aa5d/eng/resolveContract.targets#L83-L88
APICompat runs in the outer build for multi-targeting projects and without that condition, validation for all inner builds would be skipped, not just for the one that produces a PNSE assembly.
weshaggard
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Apr 11, 2024
Just updated the dead link to point to the PR that remove the tool dotnet/arcade#14328. At some point we will want to move to the new tool which is tracked at #33433
weshaggard
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Apr 12, 2024
Just updated the dead link to point to the PR that remove the tool dotnet/arcade#14328. At some point we will want to move to the new tool which is tracked at #33433
lmolkova
pushed a commit
to lmolkova/azure-sdk-for-net
that referenced
this pull request
Apr 12, 2024
Just updated the dead link to point to the PR that remove the tool dotnet/arcade#14328. At some point we will want to move to the new tool which is tracked at Azure#33433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APICompat got re-implemented on top of Microsoft.CodeAnalysis and now lives in dotnet/sdk as v2: https://github.com/dotnet/sdk/tree/main/src/Compatibility/ApiCompat. It also became a shipping product with .NET 6.
The source code was kept around for some time so that consumers could move to the new tooling. Now seems the right time to finally delete the code-base.
This tool was already excluded in source build so the deletion won't result in a build break. If there are still some repos that depend on the live version of APICompat v1, they will just not get a new dependency update for it. The code base has been frozen anyway so consumers shouldn't be impacted by this.
To double check: