Remove option to clone inner source during source-build

[MichaelSimons]

Related to dotnet/source-build#4117

[ViktorHofer]

Unfortunately this is a breaking change as the PrepareInnerSourceBuildRepoRoot target is referenced in a few repos: https://github.com/search?q=repo%3Adotnet%2Fdotnet%20PrepareInnerSourceBuildRepoRoot&type=code

I would rename this back to the old target name. CopyInnerSourceBuildRepoRoot and CloneInnerSourceBuildRepoRoot aren't used anywhere outside and can be safely removed.

[MichaelSimons]

Unfortunately this is a breaking change as the PrepareInnerSourceBuildRepoRoot target is referenced in a few repos: https://github.com/search?q=repo%3Adotnet%2Fdotnet%20PrepareInnerSourceBuildRepoRoot&type=code

I would rename this back to the old target name. CopyInnerSourceBuildRepoRoot and CloneInnerSourceBuildRepoRoot aren't used anywhere outside and can be safely removed.

Thanks for the catch. That was a silly oversite on my part. I pushed an update.

[mmitche]

SBE isn't dependent on inner-clone behavior, is it?

[NikolaMilosavljevic]

SBE isn't dependent on inner-clone behavior, is it?

We are using inner-clone (clone or copy) for SBE, in VMR build, to avoid file mutations.

[mmitche]

Cool, I see how SBE is using a copy right now.