Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TargetFramework.Sdk in SymStore.targets #4858

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Support TargetFramework.Sdk in SymStore.targets #4858

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c4296
Support TargetFramework.Sdk in SymStore.targets
ViktorHofer Feb 17, 2020
f734635
Update SymStore.targets
ViktorHofer Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/tools/SymStore.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
<_BuildsPortablePdb>false</_BuildsPortablePdb>
<_BuildsPortablePdb Condition="'$(DebugType)' == 'portable' or '$(DebugType)' == 'embedded'">true</_BuildsPortablePdb>

<_SymStoreOutputDir>$(ArtifactsSymStoreDirectory)$(MSBuildProjectName)\$(TargetFramework)\</_SymStoreOutputDir>
<_SymStoreTargetFramework>$(TargetFramework)</_SymStoreTargetFramework>
<!-- Support Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk TargetFrameworkSuffix property. -->
Copy link
Member

@tmat tmat Feb 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to fix Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk and link it here in a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: #4859

<_SymStoreTargetFramework Condition="'$(TargetFrameworkSuffix)' != ''">$(_SymStoreTargetFramework)-$(TargetFrameworkSuffix)</_SymStoreTargetFramework>
<_SymStoreOutputDir>$(ArtifactsSymStoreDirectory)$(MSBuildProjectName)\$(_SymStoreTargetFramework)\</_SymStoreOutputDir>
<_SymStorePdbPath>$(_SymStoreOutputDir)$(TargetName).pdb</_SymStorePdbPath>

<!-- By default publish Windows PDBs only for shipping components -->
Expand Down