Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate init-compiler with dotnet/runtime #7886

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Sep 13, 2021

find-native-compiler.sh in arcade and init-compiler.sh in runtime are duplicate scripts. The one in the runtime repo is more up-to-date.

This PR replaces find-native-compiler.sh with copy of init-compiler.sh from runtime repo, so we will need to maintain supported native compilers in just one place, instead of two.

@am11
Copy link
Member Author

am11 commented Sep 13, 2021

cc @jkoritzinsky, @janvorli

e.g. the llvm-ld changes (among other things) are not available in find-native-compiler.sh due to this maintenance overhead.

@am11 am11 force-pushed the feature/native-compiler branch 2 times, most recently from 0878abc to 3d71954 Compare September 13, 2021 07:12
@jkoritzinsky jkoritzinsky merged commit 70afc8b into dotnet:main Sep 13, 2021
@am11 am11 deleted the feature/native-compiler branch September 13, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants