Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in CoreClrConfigurationDetection #8222

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Fix regression in CoreClrConfigurationDetection #8222

merged 1 commit into from
Nov 26, 2021

Commits on Nov 26, 2021

  1. Fix regression in CoreClrConfigurationDetection 

    In 16988fc the refactoring added `IsGCStress` and used it in the `IsStressTest` property.
However the `GetEnvironmentVariableValue("GCStress") != string.Empty` is always true since `GetEnvironmentVariableValue` will return the string "0" if the env variable isn't set.

This in turn caused `StressModeApplies` to return false for `RuntimeTestModes.RegularRun` which made the `SkipOnCoreClr` attribute a no-op in regular runs.
    @akoeplinger
    akoeplinger committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b4d3987 View commit details
    Browse the repository at this point in the history