PR feedback.

.editorconfig

@@ -476,3 +476,6 @@ dotnet_diagnostic.IDE0005.severity = silent
 [{*.razor.cs,src/Aspire.Dashboard/Components/**.cs}]
 # CA2007: Consider calling ConfigureAwait on the awaited task
 dotnet_diagnostic.CA2007.severity = silent
+
+[*.{cs,vb}]
+dotnet_diagnostic.ASPIREEVENTING001.severity = none

Directory.Packages.props

@@ -112,7 +112,6 @@
     <PackageVersion Include="MySqlConnector.DependencyInjection" Version="2.3.6" />
     <PackageVersion Include="MySqlConnector.Logging.Microsoft.Extensions.Logging" Version="2.1.0" />
     <PackageVersion Include="NATS.Net" Version="2.3.2" />
-    <PackageVersion Include="Npgsql" Version="8.0.3" />
     <PackageVersion Include="Npgsql.DependencyInjection" Version="8.0.3" />
     <PackageVersion Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.4" />
     <PackageVersion Include="Oracle.EntityFrameworkCore" Version="8.23.50" />

src/Aspire.Hosting.Azure.EventHubs/AzureEventHubsExtensions.cs

@@ -172,7 +172,6 @@ public static IResourceBuilder<AzureEventHubsResource> RunAsEmulator(this IResou
             configureContainer(surrogateBuilder);
         }
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         builder.ApplicationBuilder.Eventing.Subscribe<AfterEndpointsAllocatedEvent>((e, ct) =>
         {
             var eventHubsEmulatorResources = builder.ApplicationBuilder.Resources.OfType<AzureEventHubsResource>().Where(x => x is { } eventHubsResource && eventHubsResource.IsEmulator);
@@ -227,7 +226,6 @@ public static IResourceBuilder<AzureEventHubsResource> RunAsEmulator(this IResou
             return Task.CompletedTask;
 
         });
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         return builder;
     }

src/Aspire.Hosting.Kafka/KafkaBuilderExtensions.cs

@@ -64,7 +64,6 @@ public static IResourceBuilder<KafkaServerResource> WithKafkaUI(this IResourceBu
                 .WithHttpEndpoint(targetPort: KafkaUIPort)
                 .ExcludeFromManifest();
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
             builder.ApplicationBuilder.Eventing.Subscribe<AfterEndpointsAllocatedEvent>((e, ct) =>
             {
                 var kafkaResources = builder.ApplicationBuilder.Resources.OfType<KafkaServerResource>();
@@ -84,7 +83,6 @@ public static IResourceBuilder<KafkaServerResource> WithKafkaUI(this IResourceBu
 
                 return Task.CompletedTask;
             });
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
             configureContainer?.Invoke(kafkaUiBuilder);
 

src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs

@@ -88,7 +88,6 @@ public static IResourceBuilder<T> WithPhpMyAdmin<T>(this IResourceBuilder<T> bui
                                                 .WithBindMount(configurationTempFileName, "/etc/phpmyadmin/config.user.inc.php")
                                                 .ExcludeFromManifest();
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         builder.ApplicationBuilder.Eventing.Subscribe<AfterEndpointsAllocatedEvent>((e, ct) =>
         {
             var mySqlInstances = builder.ApplicationBuilder.Resources.OfType<MySqlServerResource>();
@@ -143,7 +142,6 @@ public static IResourceBuilder<T> WithPhpMyAdmin<T>(this IResourceBuilder<T> bui
 
             return Task.CompletedTask;
         });
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         configureContainer?.Invoke(phpMyAdminContainerBuilder);
 

src/Aspire.Hosting.PostgreSQL/PostgresBuilderExtensions.cs

@@ -93,7 +93,6 @@ public static IResourceBuilder<T> WithPgAdmin<T>(this IResourceBuilder<T> builde
                                                  .WithBindMount(Path.GetTempFileName(), "/pgadmin4/servers.json")
                                                  .ExcludeFromManifest();
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
             builder.ApplicationBuilder.Eventing.Subscribe<AfterEndpointsAllocatedEvent>((e, ct) =>
             {
                 var serverFileMount = pgAdminContainer.Annotations.OfType<ContainerMountAnnotation>().Single(v => v.Target == "/pgadmin4/servers.json");
@@ -140,7 +139,6 @@ public static IResourceBuilder<T> WithPgAdmin<T>(this IResourceBuilder<T> builde
 
                 return Task.CompletedTask;
             });
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
             configureContainer?.Invoke(pgAdminContainerBuilder);
 

src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs

@@ -63,7 +63,6 @@ public static IResourceBuilder<RedisResource> WithRedisCommander(this IResourceB
                                       .WithHttpEndpoint(targetPort: 8081, name: "http")
                                       .ExcludeFromManifest();
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
             builder.ApplicationBuilder.Eventing.Subscribe<AfterEndpointsAllocatedEvent>((e, ct) =>
             {
                 var redisInstances = builder.ApplicationBuilder.Resources.OfType<RedisResource>();
@@ -89,7 +88,6 @@ public static IResourceBuilder<RedisResource> WithRedisCommander(this IResourceB
 
                 return Task.CompletedTask;
             });
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
             configureContainer?.Invoke(resourceBuilder);
 

src/Aspire.Hosting/BuiltInDistributedApplicationEventSubscriptionHandlers.cs

@@ -4,8 +4,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
-
 internal static class BuiltInDistributedApplicationEventSubscriptionHandlers
 {
     public static Task ExcludeDashboardFromManifestAsync(BeforeStartEvent beforeStartEvent, CancellationToken _)

src/Aspire.Hosting/Dcp/ApplicationExecutor.cs

@@ -133,10 +133,8 @@ public async Task RunApplicationAsync(CancellationToken cancellationToken = defa
 
             await CreateContainersAndExecutablesAsync(cancellationToken).ConfigureAwait(false);
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
             var afterResourcesCreatedEvent = new AfterResourcesCreatedEvent(serviceProvider, _model);
             await eventing.PublishAsync(afterResourcesCreatedEvent, cancellationToken).ConfigureAwait(false);
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
             foreach (var lifecycleHook in _lifecycleHooks)
             {
@@ -895,10 +893,8 @@ private async Task CreateContainersAndExecutablesAsync(CancellationToken cancell
         var toCreate = _appResources.Where(r => r.DcpResource is Container || r.DcpResource is Executable || r.DcpResource is ExecutableReplicaSet);
         AddAllocatedEndpointInfo(toCreate);
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         var afterEndpointsAllocatedEvent = new AfterEndpointsAllocatedEvent(serviceProvider, _model);
         await eventing.PublishAsync(afterEndpointsAllocatedEvent, cancellationToken).ConfigureAwait(false);
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         foreach (var lifecycleHook in _lifecycleHooks)
         {

src/Aspire.Hosting/DistributedApplication.cs

@@ -346,11 +346,9 @@ internal async Task ExecuteBeforeStartHooksAsync(CancellationToken cancellationT
 
         try
         {
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
             var beforeStartEvent = new BeforeStartEvent(_host.Services, _host.Services.GetRequiredService<DistributedApplicationModel>());
             var eventing = _host.Services.GetRequiredService<IDistributedApplicationEventing>();
             await eventing.PublishAsync(beforeStartEvent, cancellationToken).ConfigureAwait(false);
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
             var lifecycleHooks = _host.Services.GetServices<IDistributedApplicationLifecycleHook>();
             var appModel = _host.Services.GetRequiredService<DistributedApplicationModel>();

src/Aspire.Hosting/DistributedApplicationBuilder.cs

@@ -18,8 +18,6 @@
 
 namespace Aspire.Hosting;
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
-
 /// <summary>
 /// A builder for creating instances of <see cref="DistributedApplication"/>.
 /// </summary>

tests/Aspire.Hosting.MySql.Tests/AddMySqlTests.cs

@@ -242,9 +242,7 @@ public async Task SingleMySqlInstanceProducesCorrectMySqlHostsVariable(string co
         // Add fake allocated endpoints.
         mysql.WithEndpoint("tcp", e => e.AllocatedEndpoint = new AllocatedEndpoint(e, "localhost", 5001, containerHost));
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         await builder.Eventing.PublishAsync<AfterEndpointsAllocatedEvent>(new(app.Services, app.Services.GetRequiredService<DistributedApplicationModel>()));
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         var myAdmin = builder.Resources.Single(r => r.Name.EndsWith("-phpmyadmin"));
 
@@ -287,9 +285,7 @@ public void WithPhpMyAdminProducesValidServerConfigFile(string containerHost)
         using var app = builder.Build();
         var appModel = app.Services.GetRequiredService<DistributedApplicationModel>();
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         builder.Eventing.PublishAsync<AfterEndpointsAllocatedEvent>(new(app.Services, app.Services.GetRequiredService<DistributedApplicationModel>()));
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         using var stream = File.OpenRead(volume.Source!);
         var fileContents = new StreamReader(stream).ReadToEnd();

tests/Aspire.Hosting.PostgreSQL.Tests/AddPostgresTests.cs

@@ -416,9 +416,7 @@ public async Task WithPostgresProducesValidServersJsonFile(string containerHost)
 
         using var app = builder.Build();
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         await builder.Eventing.PublishAsync<AfterEndpointsAllocatedEvent>(new(app.Services, app.Services.GetRequiredService<DistributedApplicationModel>()));
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         using var stream = File.OpenRead(volume.Source!);
         var document = JsonDocument.Parse(stream);

tests/Aspire.Hosting.Redis.Tests/AddRedisTests.cs

@@ -165,9 +165,7 @@ public async Task SingleRedisInstanceProducesCorrectRedisHostsVariable(string co
         // Add fake allocated endpoints.
         redis.WithEndpoint("tcp", e => e.AllocatedEndpoint = new AllocatedEndpoint(e, "localhost", 5001, containerHost));
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         await builder.Eventing.PublishAsync<AfterEndpointsAllocatedEvent>(new(app.Services, app.Services.GetRequiredService<DistributedApplicationModel>()));
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         var commander = builder.Resources.Single(r => r.Name.EndsWith("-commander"));
 
@@ -193,9 +191,7 @@ public async Task MultipleRedisInstanceProducesCorrectRedisHostsVariable(string
         redis1.WithEndpoint("tcp", e => e.AllocatedEndpoint = new AllocatedEndpoint(e, "localhost", 5001, containerHost));
         redis2.WithEndpoint("tcp", e => e.AllocatedEndpoint = new AllocatedEndpoint(e, "localhost", 5002, "host2"));
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         await builder.Eventing.PublishAsync<AfterEndpointsAllocatedEvent>(new (app.Services, app.Services.GetRequiredService<DistributedApplicationModel>()));
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 
         var commander = builder.Resources.Single(r => r.Name.EndsWith("-commander"));
 

tests/Aspire.Hosting.Tests/Dcp/ApplicationExecutorTests.cs

@@ -745,7 +745,6 @@ private static ApplicationExecutor CreateAppExecutor(
             configuration = builder.Build();
         }
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
         return new ApplicationExecutor(
             NullLogger<ApplicationExecutor>.Instance,
             NullLogger<DistributedApplication>.Instance,
@@ -765,7 +764,6 @@ private static ApplicationExecutor CreateAppExecutor(
             new DistributedApplicationEventing(),
             serviceProvider
         );
-#pragma warning restore ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
     }
 
     private sealed class TestHostApplicationLifetime : IHostApplicationLifetime

tests/Aspire.Hosting.Tests/Eventing/DistributedApplicationBuilderEventingTests.cs

@@ -1,8 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#pragma warning disable ASPIREEVENTING001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
-
 using Aspire.Hosting.Eventing;
 using Aspire.Hosting.Utils;
 using Microsoft.Extensions.DependencyInjection;