Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Npgsql Meter for Npgsql based components. #442

Closed
davidfowl opened this issue Oct 22, 2023 · 0 comments · Fixed by #630
Closed

Enable Npgsql Meter for Npgsql based components. #442

davidfowl opened this issue Oct 22, 2023 · 0 comments · Fixed by #630
Assignees
@eerhardt
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Milestone
preview-1 week

Comments

@davidfowl
Copy link
Member

davidfowl commented Oct 22, 2023 •
edited
Loading

As of the rc2 version of Npgsql there's now a meter that exposes metrics, see npgsql/npgsql#5158. We should update the Npgsql components (AddNpgsqlDbContext and AddNpgsqlDataSource) to enable it instead of using the event counters.
@davidfowl davidfowl changed the title Enable Npgsql Meter when calling AddNpgsqlDbContext and Add Enable Npgsql Meter for Npgsql based components. Oct 22, 2023
@davidfowl davidfowl added the area-integrations Issues pertaining to Aspire Integrations packages label Oct 22, 2023
@eerhardt eerhardt added this to the preview-1 week milestone Oct 23, 2023
@eerhardt eerhardt mentioned this issue Nov 1, 2023
Closed
eerhardt added a commit that referenced this issue Nov 1, 2023
@eerhardt
Enable Npgsql Meter instead of using EventCounters
6dcbe40 
Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442
@eerhardt eerhardt mentioned this issue Nov 1, 2023
Merged
@eerhardt eerhardt self-assigned this Nov 1, 2023
eerhardt added a commit that referenced this issue Nov 1, 2023
@eerhardt
Fix database issues (#630)
a617a54 
* Allow for configuring DbContextOptions in EF Components

Fix #438

* Enable Npgsql Meter instead of using EventCounters

Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442

* Update Telemetry doc for updated Metrics
eerhardt added a commit that referenced this issue Nov 1, 2023
@eerhardt
Fix database issues (#630)
8a18a05 
* Allow for configuring DbContextOptions in EF Components

Fix #438

* Enable Npgsql Meter instead of using EventCounters

Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442

* Update Telemetry doc for updated Metrics
@eerhardt eerhardt mentioned this issue Nov 1, 2023
Merged
joperezr pushed a commit that referenced this issue Nov 1, 2023
@eerhardt
Fix database issues (#630) (#637)
f990b7b 
* Allow for configuring DbContextOptions in EF Components

Fix #438

* Enable Npgsql Meter instead of using EventCounters

Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442

* Update Telemetry doc for updated Metrics
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
preview-1 week
Development

Successfully merging a pull request may close this issue.

Fix database issues dotnet/aspire
2 participants
@davidfowl @eerhardt