Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs don't resize properly to smaller screen size #513

Closed
JamesNK opened this issue Oct 26, 2023 · 5 comments
Closed

Dialogs don't resize properly to smaller screen size #513

JamesNK opened this issue Oct 26, 2023 · 5 comments
Assignees

Comments

@JamesNK
Copy link
Member

JamesNK commented Oct 26, 2023

dialog-size

Dialog grid should resize to fit.

@tlmii
Copy link
Member

tlmii commented Oct 26, 2023

I think the current plan is to get rid of the dialogs anyway.

@JamesNK
Copy link
Member Author

JamesNK commented Oct 26, 2023

That's true. I'm guessing that will be post preview though.

If we're happy with this behavior for preview then it could be closed.

@tlmii
Copy link
Member

tlmii commented Oct 26, 2023

I'm actually looking at #454 this week. If it works well enough, it might not be post-preview. But if that attempt doesn't get the 👍 , then yeah we can look at tweaking this (or punting to post-preview as needed)

@tlmii
Copy link
Member

tlmii commented Oct 30, 2023

If #561 goes in, we can close this. If not, we can look at a smaller update to clean this up for preview.

@dbreshears dbreshears added this to the preview-1 week milestone Oct 30, 2023
This was referenced Oct 30, 2023
@DamianEdwards
Copy link
Member

Looks like #561 went in so closing this out.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants