Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview1] Tweak modal sizing #627

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[release/8.0-preview1] Tweak modal sizing #627

merged 1 commit into from
Nov 2, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Nov 1, 2023

Resolves #513. This fix is just for Preview1 since we've already moved on from the modals in main. Making as minimal of a change as possible to address the issue.

Instead of making the dialog width automatic based on its content, and locking the content to a specific width (1000px), we invert that and lock the dialog width to 1000px and set the grid container to size to 100% of its container. This handles the default scenario of resizing the browser window when you have not resized any of the columns in the grid.

There's a second scenario similar to what's shown in the window where you resize the grid columns. This also resizes the grid and allows it to be wider than the dialog. The user can get themselves into a situation where they made the column so large they can't see the resize grab handles anymore to make it smaller again (in addition to the rendering looking like it does in #513). A second variant of this happens when the header text is too wide even after wrapping. For that, we change the dialog to allow horizontal scrolling.
 
If we were keeping the modals, we'd probably want to do more to make the resizing more adaptive to smaller screens. But this is just a small fix to prevent the bad rendering seen in #513.

Without wide header text or grid resizing:
image
image
image

With wide header text:
image

With grid columns resized:
image

@davidfowl davidfowl merged commit 02a5441 into dotnet:release/8.0-preview1 Nov 2, 2023
6 checks passed
@tlmii tlmii deleted the dev/modal-sizing branch November 2, 2023 05:11
joperezr added a commit that referenced this pull request Nov 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants