Detail view feedback

[JamesNK]

Improvements:

• Resizable e.g. https://www.fluentui-blazor.net/Splitter
• Position and size are remembered
• Togglable e.g.
  • Click View for environment variables on service1 shows the view
  • Click View for environment variables on service1 now hides the view
• Indication of what is open e.g. clicking View for environment variables on service1 then highlights the button. Probably should wait until we decide how the detail view is opened (button vs row) before spending time on this Moved to Standardize grid selection and selected row display #1081
• Detail view settings are remembered when switching between data. e.g. Moved to Details views should remember their state #1080
  • Click View for environment variables on service1
  • Select unhide values button
  • Click View for environment variables on service2. The unhide values setting is remembered
  • Whether values are hidden, column sizes, filter text should be remembered. Doesn't need to persist between reload

[JamesNK]

cc @tlmii

[tlmii]

All great feedback and pretty in line with what I was thinking. A few quick comments now:

• Resizable e.g. https://www.fluentui-blazor.net/Splitter

This was always the goal, but we need some improvements to the splitter - e.g. being able to hide the splitter bar and secondary panel. I've got notes on it from my testing, need to file an issue.

• Togglable e.g.

  • Click View for environment variables on service1 shows the view

  • Click View for environment variables on service1 now hides the view

With the current button I think this makes sense, but it doesn't feel quite right if we do row selection (which I think is the goal). I'm not against it though.

• Indication of what is open e.g. clicking View for environment variables on service1 then highlights the button. Probably should wait until we decide how the detail view is opened (button vs row) before spending time on this

I've got this working now, under the assumption we will do row selection. Even with the button, though, the selected row indication is nice. Just need to pick the appropriate shade of gray...

[danmoseley]

@tlmii is there any remaining piece that isn't on your plate (the splitter)? looking for issues to label help wanted

[tlmii]

@danmoseley I've got a few pieces of this in flight at the moment, will likely have PRs Monday/Tuesday. I'll split off remaining work into other issues and they'd likely be good for help wanted

[tlmii]

Some of this feedback has been addressed. Still need to address (or split off issues for) the rest, probably starting with how selection happens (e.g. full row selection for all grids like we have for spans?). That might be a topic to do in conjunction with #892 if we're making significant changes to both the summary and details views there.

[tlmii]

Closing this issue as things are either fixed (first two bullet points) or have individual issues for them (last two bullet points)