-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all resources on a single page in the dashboard #892
Comments
One thing to sort out here will be how we handle the extra details (whatever current columns don't fit nicely into the new "details" column) combined with the environment variables. The trace details page's details view has a similar concept already (there are two grids in that details view) so we could potentially start with something like that and then iterate. A true "details" panel (not just a property grid) would probably be more appropriate long term for the first part of that. But that doesn't have to be where we start.
Here's the things that are not (directly) in common between the resource types that are on the grid now (so we can discuss which should be merged into a details column and which should be moved to the details pane):
Seems like Process Id/Container Id could be shared in a column (or combined into name column). Source Location, Container Image, Ports, Working Directory and Arguments could be combined, but they'd need to be labeled, which would make that column a little messy. But I'm not sure which of those we'd want to actually push off to a details pane. Any of them could be helpful at-a-glance information in specific scenarios. |
I think the barebone necessity on single resources page would be to know the state of resources, Running status, any errors, replicas, endpoints. Most of those are kind of common between pages. That would be most useful. There are also other things which my be useful for particular resource kind, may be add those columns only when filtered on that resource kind? |
Agreed that the various Id columns could just become unified in a single "Id" column. One thought is that "Source Location", "Container Image", and "Working Directory" could all be unified into something like a "Location" column? Might be too much of a forced fit though. Endpoints should for sure be in the default view so that it's easy to click-through to the URLs. Alternatively we could keep the columns on all the time and just have them be empty (or n/a) for resource types they don't apply to. Perhaps we drop project "Source Location" by default anyway as I'm starting to question its value. We might want to make the displayed columns configurable in the future (a bit like in Windows Task Manager). |
Hello dotnet team, if PR is welcome for this issue, I can start working on it. If it is suitable for everyone, I can make your improvement suggestions through concrete pages and codes after opening the pull-request. |
It seems to me it would be fairly self evident what each one is, so a generic Location header would be fine. |
@danmoseley maybe "Source" is a better fit? |
That works too. |
I took a quick stab at this yesterday so we would have something more visual to react to: Added an icon-only column for the type (separate column for sorting). Combined Name, Process Id and Container Id into the Name column. Combined Executable Path + Arguments, Container Image + Ports and Source Location into one Source column. There's obviously still some issues here:
|
Thanks - This looks great @tlmii with on hover panel display (https://www.fluentui-blazor.net/Panel) would suffice? |
Today, the dashboard has separate pages for project, container, and executable resources. This makes it cumbersome to see all resources that make up a distributed application being monitored by the dashboard, as one has to click between pages to see the various resource types and their statuses. It also provides nowhere to display custom resource types.
We should consider instead have a single "Resources" page that shows all resources by default, with the ability to filter the view by resource type (one or many). The columns in the table would need to be common enough to apply to all resource types reasonably, e.g. instead of a "project path" column for projects and "base image" for containers it would have a "Details" column that each resource type would use to display the relevant top-level details unique to that resource type. Selecting a row in the table would show the full details for that resource in the details pane, showing whatever fields make sense for the resource type.
The text was updated successfully, but these errors were encountered: