Use invariant culture when generating CSS numeric values #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
JamesNK,
drewnoakes,
smitpatel,
adamint and
kvenkatrajan
JamesNK
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #841
It looks like the cause of this issue was the CSS numeric values being localized to include commas instead of decimal point. CSS requires it be a decimal point, but by default both
ToString()and string interpolation will use the current culture.I changed the one line that appears to be the culprit in
TraceDetail.razorand one more inTraceDetail.razor.csthat could be generating invalid values. For the latter, it was string interpolation, where the guidance in .NET 6+ is to usestring.Create.I added #1048 to discuss the long term issues here because I think the string interpolation variant of this issue may not be as easy to solve.