Update eShopLite to not call basket checkout if no current basket #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
approved these changes
Nov 29, 2023
| if (customerBasket is not null) | ||
| { | ||
| await BasketClient.CheckoutBasketAsync("user"); | ||
| } | ||
|
|
||
| // Preserve query string | ||
| Navigation.NavigateTo($"/{new Uri(Navigation.Uri).Query}"); |
There was a problem hiding this comment.
Should the NavigateTo only be called if there is a customer basket as well?
There was a problem hiding this comment.
We're still in a POST request so we need to redirect (post-redirect-get).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak to not attempt to call the checkout basket service if the call to get the basket returned null (meaning there's no current user basket).
Port of dotnet/aspire-samples#51
This started happening when #361 was merged I think.