-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show file name in dashboard resources page #1232
Conversation
src/Aspire.Dashboard/Components/ResourcesGridColumns/SourceColumnDisplay.razor
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it this way. But glad to see other opinions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
62e57bf
to
e309ab7
Compare
@kvenkatrajan What you've proposed is a lot more complicated. Can you open a local folder location from a browser? I've never seen that before. Do you want to you create a new issue that suggests further improvements or do you want it done as part of this PR? |
AFAIK file:// won't work for the vast majority of users, so I don't know a viable way of implementing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely looks cleaner, no doubt about that. I have some concerns about the filename by itself not being sufficient in multi-repo scenarios (multiple Api.csproj files for different microservices, for instance). But the source isn't really intended to be an identifier - that's what the name's for. So I think it's likely ok, and we'll get feedback if not.
I don't think either Edge or Chrome support opening file:///
URLs by default, so that's likely a non-starter unfortunately. The copy path is likely the best we can do there.
Sorry just catching up on the PRs. Yes agreed Open Folder Location to file path here - though a copy button would help retrieving the file path. Here's the issue to track the copy path functionality : #1309 |
@kvenkatrajan we could have a copy path button but we cannot do |
Fixes #1216
Fixes #1273
Only display the project/exe name in the dashboard. This is the most important piece of information and only showing the name prevents it from being trimmed in lower resolutions. See before screenshots below to see this happening.
Full paths are available in the tool tip.
Opinions on the UI change? I think it is better, but I want some consensus before merging.
eShop
Before:
After:
darp
Before:
After: