Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize dashboard Controls folder #1246

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

adamint
Copy link
Member

@adamint adamint commented Dec 6, 2023

Part of #955, I'm purposely not bunching every file change together 1) to reduce the size of this PR, and 2) because I'm worried that we'll end up with a lot of merge conflicts if the PR sits for a while, considering that almost every razor file is going to be touched.

This localizes all razor components inside Components/Controls and enables localization.

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Consider bringing over the .gitattributes entry from dotnet/project-system that configures xlf files to collapse by default in PRs on GitHub.

@adamint
Copy link
Member Author

adamint commented Dec 6, 2023

Good call, thanks @drewnoakes

@adamint adamint merged commit ee3c34d into dotnet:main Dec 6, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants