Option on metrics histograms to show count #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
drewnoakes,
smitpatel,
tlmii,
adamint and
kvenkatrajan
JamesNK
commented
Dec 7, 2023
Comment on lines
130
to
131
| <value>Show Spec Only</value> | ||
| <note>Spec means from the resource specification</note> |
There was a problem hiding this comment.
I edited ControlsStrings in the VS resource editor and it removed all the values with note.
@adamint Do you know what happened and how I can fix it?
There was a problem hiding this comment.
Looks like a bug in the Managed Resource Editor. Paging @melytc and @haileymck to investigate. cc @kvenkatrajan
There was a problem hiding this comment.
What should I do to fix this? I could revert all resx changes, hardcode the text, and create an issue to update in the future.
I have preview and int-preview on my dev machine. Does the bug impact both?
There was a problem hiding this comment.
Also happens in int preview
drewnoakes
reviewed
Dec 7, 2023
drewnoakes
approved these changes
Dec 7, 2023
JamesNK
force-pushed
the
jamesnk/metrics-count
branch
from
e36812b
to
efb23ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965
Adds a switch to histogram charts to display the count of the instrument, e.g. the number of HTTP requests.
Demo:
