Add support for user defined entrypoint in containers #1341
Conversation
dotnet-issue-labeler
bot
added
the
area-app-model
|
Did you... read my mind? #1342 |
| @@ -578,6 +578,11 @@ private async Task CreateContainersAsync(IEnumerable<AppResource> containerResou | |||
| } | |||
| } | |||
|
|
|||
| if (modelContainerResource is ContainerResource containerResource) | |||
| { | |||
| dcpContainerResource.Spec.Command = containerResource.Entrypoint; | |||
There was a problem hiding this comment.
Is this conflating CMD and ENTRYPOINT? https://docs.docker.com/engine/reference/builder/#understand-how-cmd-and-entrypoint-interact
There was a problem hiding this comment.
Is it? I don't have visibility into what command maps to internally in dcp, but I was told this is for entrypoint.
There was a problem hiding this comment.
That's a question for @karolz-ms
There was a problem hiding this comment.
DCP is attempting to bypass the whole command vs entrypoint madness, it has just one option, Command which if set, that is the binary that will be run, no exceptions. So it is the equivalent of --entrypoint (and --entrypoint is the option that is used under the covers with Docker).
There was a problem hiding this comment.
I see. So with DCP it's currently not possible to just pass args to a container's pre-defined entry point?
There was a problem hiding this comment.
It is, you just use Args property for that
There was a problem hiding this comment.
Ok it makes sense now. I was confused how this was working using just the existing WithArgs method, but it turns out it's because the mssql container is defined like this:
BrennanConroy
force-pushed
the
brecon/command
branch
from
44be418
to
805de04
Compare
Should we add more
AddContaineroverloads for entrypoint? Should we add aWithEntrypointextension method?Microsoft Reviewers: Open in CodeFlow