[release/8.0-preview2] Added support for adding connection strings to non-resources

[github-actions]

Backport of #1350 to release/8.0-preview2

/cc @mitchdenny @davidfowl

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

• The PR target branch is release/X.0-staging, not release/X.0.

• If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Microsoft Reviewers: Open in CodeFlow

[eerhardt]

My 2 comments can be made in main, we don't have to block the backport PR for them.

LGTM.

[eerhardt]

Suggested change

	var connectionStringName = $"{ConnectionStringEnvironmentName}{connectionString.Name}";
	return builder.WithEnvironment(context =>
	{
	var connectionStringValue = connectionString.Value ??
	builder.ApplicationBuilder.Configuration.GetConnectionString(connectionString.Name);
	if (string.IsNullOrEmpty(connectionStringValue))
	{
	throw new DistributedApplicationException($"A connection string for '{connectionString.Name}' could not be retrieved.");
	}
	if (builder.Resource is ContainerResource)
	{
	connectionStringValue = HostNameResolver.ReplaceLocalhostWithContainerHost(connectionStringValue, builder.ApplicationBuilder.Configuration);
	}
	context.EnvironmentVariables[connectionStringName] = connectionStringValue;
	return builder.WithEnvironment(context =>
	{
	var connectionStringValue = connectionString.Value ??
	builder.ApplicationBuilder.Configuration.GetConnectionString(connectionString.Name);
	if (string.IsNullOrEmpty(connectionStringValue))
	{
	throw new DistributedApplicationException($"A connection string for '{connectionString.Name}' could not be retrieved.");
	}
	if (builder.Resource is ContainerResource)
	{
	connectionStringValue = HostNameResolver.ReplaceLocalhostWithContainerHost(connectionStringValue, builder.ApplicationBuilder.Configuration);
	}
	context.EnvironmentVariables[$"{ConnectionStringEnvironmentName}{connectionString.Name}"] = connectionStringValue;

You are already capturing connectionString into the lambda, so you might as well make this name in the lambda instead of making the capture object bigger.

[davidfowl]

I prefer to have the exact same code in main and preview2.

[eerhardt]

Like I said above "My 2 comments can be made in main, we don't have to block the backport PR for them.".