Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace note with comment in resx files #1374

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Replace note with comment in resx files #1374

merged 2 commits into from
Dec 13, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 13, 2023

<note> tags caused VS 2022 preview and VS 2022 int preview to remove values when editing resx files.

Some files already used <comment> so this makes resx consistent.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adamint do you know how we ended up with note?

FYI @melytc @haileymck

@adamint
Copy link
Member

adamint commented Dec 13, 2023

Huh, I completely missed this. No clue, but I was directly modifying the files so this might have been a mistyped once, copied a hundred times situation. Sorry for the oversight, LGTM

@JamesNK JamesNK merged commit 64bd924 into main Dec 13, 2023
8 checks passed
@JamesNK JamesNK deleted the jamesnk/resx-fix branch December 13, 2023 02:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants