Fix replica id trimming #1409
Merged
Fix replica id trimming #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
davidfowl,
JamesNK,
drewnoakes,
smitpatel,
karolz-ms and
adamint
drewnoakes
approved these changes
Dec 15, 2023
davidfowl
approved these changes
Dec 15, 2023
Would you accept an issue instead (for the moment)? |
|
|
|
backport to p2? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1408 for main
Old code assumed that there'd only be a hyphen if there was a replica id at the end, but names can have hyphens (and in fact eShop has them). Change it to just strip off the last hyphen and everything after it instead.
Microsoft Reviewers: Open in CodeFlow