Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve All checkbox behavior and instrument list #1461

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 19, 2023

Change metrics tag All option to go from intermediate checked to checked. This is consistent with how most checkboxes in windows and the web work.

Change instrument list on metrics page to use data grid.

Before:
image

After:
image

Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK changed the title Improve metrics tag multi-select and instrument list Improve All tag behavior and instrument list Dec 19, 2023
@JamesNK JamesNK changed the title Improve All tag behavior and instrument list Improve All checkbox behavior and instrument list Dec 19, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Dec 21, 2023

Could someone take a look 🙏 I'd like to merge before conflicts start being created in the resource files.

@drewnoakes
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK enabled auto-merge (squash) December 22, 2023 01:47
@JamesNK JamesNK merged commit 0748000 into main Dec 22, 2023
8 checks passed
@JamesNK JamesNK deleted the jamesnk/metrics-datagrid branch December 22, 2023 02:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants