Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce splitter bar size to 5 in summary view #1474

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

adamint
Copy link
Member

@adamint adamint commented Dec 20, 2023

I reduced the bar size from 8 to 5 in summary view. It's still easy to land on. Let me know if it seems too thin

screenshot:
image

resolves #864

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Dec 20, 2023
@davidfowl
Copy link
Member

Seems too thin

@adamint
Copy link
Member Author

adamint commented Dec 20, 2023

@davidfowl can you suggest a width

@JamesNK
Copy link
Member

JamesNK commented Dec 20, 2023

Better. I actually think it could be 1px thinner 😄

For a point of comparison, this is what a splitter looks like in the GitHub UI:
image

I don't think we should go quite that far.

@davidfowl
Copy link
Member

Wait is that the border px, that's fine 😄

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size looks good to me. Any smaller and it starts to become inaccessible to folks with fine motor control challenges.

Is the grip handle (little line inside the border) needed? That's not common in many UIs these days.

@adamint
Copy link
Member Author

adamint commented Dec 27, 2023

Is the grip handle (little line inside the border) needed? That's not common in many UIs these days.

It's part of the FluentSplitter component, so it's not really up to us whether we can remove it. fwiw, this is still a pattern used in Windows

@adamint adamint merged commit bfc103d into dotnet:main Dec 27, 2023
8 checks passed
@JamesNK
Copy link
Member

JamesNK commented Dec 28, 2023

Is the grip handle (little line inside the border) needed? That's not common in many UIs these days.

It's part of the FluentSplitter component, so it's not really up to us whether we can remove it. fwiw, this is still a pattern used in Windows

Removed with CSS - #1506

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle the splitter bar in Summary/Details View
4 participants