Add ExcludeLaunchProfile method to model #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
the
area-app-model
davidfowl
reviewed
Jan 30, 2024
mitchdenny
reviewed
Jan 30, 2024
mitchdenny
reviewed
Jan 30, 2024
|
Blocked on DCP changes. |
karolz-ms
reviewed
Jan 31, 2024
|
Feedback applied. @karolz-ms Can you double check the usage of the new annotation. Feels pretty simple. Can this change be merged now or does it need to wait for the annotation to be supported in DCP? |
We can merge now. The setting will not be effective until DCP and VS pieces are in place, but it won't do any harm. |
JamesNK
force-pushed
the
jamesnk/excludelaunchprofile
branch
from
e3884e5
to
8873c1f
Compare
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1849
There appears to be two ways to launch a project:
ExcludeLaunchProfile has been added to dotnet watch path by skipping reading launch profile.
I'm guessing ExcludeLaunchProfile needs to be passed to the IDE as an annotation. Does one exist today? What should the name/value be?
Microsoft Reviewers: Open in CodeFlow