Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-preview3] Fix histogram chart calculation #1993

Merged
merged 4 commits into from
Jan 31, 2024
Merged

[release/8.0-preview3] Fix histogram chart calculation #1993

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8128fc1
Fix histogram chart calculation
JamesNK Jan 30, 2024
c78694a
Comment
JamesNK Jan 30, 2024
57419e6
Update src/Aspire.Dashboard/Components/Controls/ChartContainer.razor.cs
JamesNK Jan 30, 2024
d5e11b3
Update src/Aspire.Dashboard/Components/Controls/ChartContainer.razor.cs
JamesNK Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Aspire.Dashboard/Components/Controls/ChartContainer.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,18 @@ protected override async Task OnParametersSetAsync()

private OtlpInstrument? GetInstrument()
{
var endDate = DateTime.UtcNow;
// Get more data than is being displayed. Histogram graph uses some historical data to calculate bucket counts.
// It's ok to get more data than is needed here. An additional date filter is applied when building chart values.
var startDate = endDate.Subtract(Duration + TimeSpan.FromSeconds(30));

var instrument = TelemetryRepository.GetInstrument(new GetInstrumentRequest
{
ApplicationServiceId = ApplicationId,
MeterName = MeterName,
InstrumentName = InstrumentName,
StartTime = DateTime.UtcNow.Subtract(Duration),
EndTime = DateTime.UtcNow,
StartTime = startDate,
EndTime = endDate,
});

if (instrument == null)
Expand Down