Update dashboard discovery to use .dll instead of executable #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-integrations
|
While I'm not against this change, have we understood yet what is the problem with the mac os executable that we are generating? I'm assuming this should be relatively easy to test, right? Correct me if I'm wrong but I think this change is changing how the dashboard is launched everywhere, and that could be risky, especially since it feels more like a bandaid trying to cover the actual issue. |
|
Updated to only special case using the .dll on Mac |
davidfowl
approved these changes
Jan 31, 2024
|
/backport to release/8.0-preview3 |
|
Started backporting to release/8.0-preview3: https://github.com/dotnet/aspire/actions/runs/7731267673 |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
…2018) * Update dashboard discovery to use .dll * Only override for Mac
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
…2018) * Update dashboard discovery to use .dll * Only override for Mac
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executable was having issues on Mac, so switching to reference the .dll since Aspire.Hosting can already handle that scenario.
Microsoft Reviewers: Open in CodeFlow