Fix for unit tests failing. #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
drewnoakes
approved these changes
Feb 1, 2024
|
/backport to release/8.0-preview3 |
|
Started backporting to release/8.0-preview3: https://github.com/dotnet/aspire/actions/runs/7735847166 |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ordering of when I run the before start lifecycle hook. I accidentally moved it after start in the DistributedApplication.StartAsync. Most folks don't use this, but we do in our local only CI tests.
This change increases the timeout waiting for the endpoints to be allocated (we need to optimize all this in P4) but also reverts the bug that I introduced.
Microsoft Reviewers: Open in CodeFlow