Remove RedisContainerResource and containerize RedisResource. #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
reviewed
Feb 5, 2024
src/Aspire.Hosting/ApplicationModel/ResourceAnnotationMutationBehavior.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Feb 5, 2024
davidfowl
approved these changes
Feb 5, 2024
radical
reviewed
Feb 5, 2024
| // this code to accomodate it. | ||
| if (behavior != ResourceAnnotationMutationBehavior.Append && behavior != ResourceAnnotationMutationBehavior.Replace) | ||
| { | ||
| throw new ArgumentOutOfRangeException(nameof(behavior), behavior, "ResourceAnnotationMutationBehavior must be either AddAppend or AddReplace."); |
There was a problem hiding this comment.
Does Add prefix need to be dropped here? If so, then maybe use nameof(..) so it is in sync.
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
…#2073) * Remove RedisContainerResource and containerize RedisResource. * Fix up tests. * Test doesn't need PublishAsContainer()..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1741
Rather than one big change that changes all resources at once, I am going do one resource at a time to allow for easier merges with other people working across the codebase.
What this PR does is remove the
AddRedisContainer(...)method and instead:RedisResourcederive fromContainerResource.IRedisResourceas it is no longer required for generic constraints.WithAnnotation(...)to support someAddReplaceandAddAppendsemantics.container.v0resource is produced.Microsoft Reviewers: Open in CodeFlow