Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Mongo Express #2091

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Adds Mongo Express #2091

merged 3 commits into from
Feb 8, 2024

Conversation

timheuer
Copy link
Member

@timheuer timheuer commented Feb 5, 2024 •
edited by dotnet-policy-service bot
Loading

Addresses #1920 by adding mongo-express to the MongoDB extensions (with resource tests)

Some notes:

  • Mongo Express cannot handle multiple hosts (support connecting to multiple hosts mongo-express/mongo-express#458) at this time so there is a diff express instance per mongodb instance (no shared admin)
  • Basic auth is used on the admin portal using default creds for mongo-express (should this be configurable in the extension method?)
  • Uses the endpoint port instead of the direct container port to handle reliable connection within the bridge docker network
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 5, 2024
@timheuer @davidfowl
Simplify ctor
c2ccde4 
PR feedback

Co-authored-by: David Fowler <[email protected]>
@timheuer timheuer marked this pull request as ready for review February 7, 2024 17:07
@davidfowl davidfowl merged commit 3a80354 into main Feb 8, 2024
8 checks passed
@davidfowl davidfowl deleted the mongoexpress branch February 8, 2024 02:29
radical pushed a commit to radical/aspire that referenced this pull request Feb 9, 2024
@timheuer @davidfowl @radical
Adds Mongo Express (dotnet#2091)
208f499 
* Adds Mongo Express to MongoDB builder extensions

* Move tests due to test refactor

* Simplify ctor

PR feedback

Co-authored-by: David Fowler <[email protected]>

---------

Co-authored-by: David Fowler <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timheuer @davidfowl