Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Extensions.Http.Resilience to 8.2 #2094

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Feb 6, 2024

This has a fix for dotnet/extensions#4770 which causes our EndToEnd tests to timeout if a service doesn't start in 100 seconds.

We can update this to the official 8.2.0 when it ships.

Microsoft Reviewers: Open in CodeFlow

This has a fix for dotnet/extensions#4770 which causes our EndToEnd tests to timeout if a service doesn't start in 100 seconds.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Feb 6, 2024
@radical
Copy link
Member

radical commented Feb 6, 2024

and maybe drop the retry from ProjectInfo.WaitForHealthyStatusAsync which shouldn't be needed now, and would surface the failure if this breaks.

@eerhardt
Copy link
Member Author

eerhardt commented Feb 6, 2024

and maybe drop the retry from ProjectInfo.WaitForHealthyStatusAsync which shouldn't be needed now, and would surface the failure if this breaks.

It is still needed because the project may return Unhealthy, which in that case it needs to retry.

@radical
Copy link
Member

radical commented Feb 6, 2024

and maybe drop the retry from ProjectInfo.WaitForHealthyStatusAsync which shouldn't be needed now, and would surface the failure if this breaks.

It is still needed because the project may return Unhealthy, which in that case it needs to retry.

right, keep missing that. Then no try/catch?

@eerhardt
Copy link
Member Author

eerhardt commented Feb 6, 2024

Then no try/catch?

That's needed because when it returns Unhealthy it also returns a 503 status code. And HttpClient.GetString ensures that the status code is a "success". So when it is a 5xx status code an exception gets thrown.

@eerhardt eerhardt enabled auto-merge (squash) February 6, 2024 14:00
@eerhardt eerhardt merged commit 2bf302b into dotnet:main Feb 6, 2024
8 checks passed
@eerhardt eerhardt deleted the UpdateHttpResilience branch February 6, 2024 16:39
eerhardt added a commit to eerhardt/aspire that referenced this pull request Feb 6, 2024
…)"

This reverts commit 2bf302b.

There is a breaking change with Grpc clients in this version.
eerhardt added a commit that referenced this pull request Feb 7, 2024
* Revert "Update Microsoft.Extensions.Http.Resilience to 8.2 (#2094)"

This reverts commit 2bf302b.

There is a breaking change with Grpc clients in this version. See dotnet/extensions#4924

* Set the EndToEnd test HttpClient timeout to infinite

This allows the Http.Resilience handlers to handle the timeout correctly.
radical pushed a commit to radical/aspire that referenced this pull request Feb 7, 2024
* Revert "Update Microsoft.Extensions.Http.Resilience to 8.2 (dotnet#2094)"

This reverts commit 2bf302b.

There is a breaking change with Grpc clients in this version. See dotnet/extensions#4924

* Set the EndToEnd test HttpClient timeout to infinite

This allows the Http.Resilience handlers to handle the timeout correctly.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants