Add resource name to annotations #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
davidfowl
reviewed
Feb 7, 2024
|
What about containers? |
That's why I asked 😆
|
|
Yes. This helps us correlate how DCPs thing resources map to appmodel resources. |
JamesNK
reviewed
Feb 8, 2024
| @@ -386,6 +386,74 @@ public async Task VerifyDockerWithBoundVolumeMountWorksWithRelativePaths() | |||
| await app.StopAsync(); | |||
| } | |||
|
|
|||
| [LocalOnlyFact("docker")] | |||
| public async Task KubernetesHasResourceNameForContainersAndExes() | |||
There was a problem hiding this comment.
It's too now, but you could write a unit test for this instead of integration. There is now an ApplicationExecutorTests file.
There was a problem hiding this comment.
Ooh, I'll need to remember that for future testing.
davidfowl
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441
Do we need to add names to other resource types?
Microsoft Reviewers: Open in CodeFlow