Theme the scrollbars in dark theme, and refactor theming support #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
JamesNK,
drewnoakes,
leslierichardson95,
adamint and
kvenkatrajan
JamesNK
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drewnoakes had wondered in #1882 if we could change the scrollbar theming to match our theming. I finally got around to doing that.
I also refactored some of the theming support generally now that things have mostly stabilized - was able to remove a bit of code on the C# side and get rid of several of the exports on the JS side, while consolidating the "initial" and "update" theming setups. Added a few more doc comments as well.
Before:
After:
Microsoft Reviewers: Open in CodeFlow