Remove inner tooltip in exception info tooltip #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
approved these changes
Feb 9, 2024
|
Is the anchor ID on copy button still required? Remove if not necessary |
It's still necessary, as we are still setting the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2146 (note: this only repros sometimes?) - previously,
window.copyTextToClipboardhad required a tooltip reference to update text of - which isn't really necessary here as we are already in a tooltip, especially because the copy/checkmark already indicate to the user that the text has been copied.Makes the tooltip optional in
window.copyTextToClipboardMicrosoft Reviewers: Open in CodeFlow