Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vector for Aspire logo in dashboard #2279

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Use vector for Aspire logo in dashboard #2279

merged 2 commits into from
Feb 17, 2024

Conversation

timheuer
Copy link
Member

@timheuer timheuer commented Feb 16, 2024

The Aspire logo in the dashboard was a 24px PNG that was rastered and missing the full brand mark elements. It also isn't in alignment with the other vector items used in the dashboard. This change uses the vector logo and scales with the other icons used in the dashboard well.

Before:
image

After:
image

Microsoft Reviewers: Open in CodeFlow

@tlmii
Copy link
Member

tlmii commented Feb 16, 2024

@timheuer I sent you a link to the design team's thread on the new logo.

I agree on the problem with it not being vectorized. That was brought up by the designer, who said the shadows in the design didn't translate to svg as well. We were only using it at one size at the moment, so I didn't think it'd be that big of an issue. I spend a lot of time zooming in app to fix little design issues, though, and it has annoyed me more than I expected.

Is your objection solely to the scaling issues or to the different design as well? It seems like its both.

@kvenkatrajan @leslierichardson95 also since yall were involved in the design discussions as well.

@timheuer
Copy link
Member Author

Thanks for the context @tlmii -- pinged the designer to see what the vector issue was. Would love our icon here to look consistent with the others in quality! Standby.

@timheuer timheuer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 16, 2024
@timheuer timheuer removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 16, 2024
@timheuer
Copy link
Member Author

@tlmii got updated vector from design -- updated PR and design validated output with 👍

@JamesNK JamesNK merged commit 0772b84 into main Feb 17, 2024
8 checks passed
@JamesNK JamesNK deleted the dashboard-logo branch February 17, 2024 00:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants