Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More changes to make dates and times consistent across dashboard #2306

Merged
merged 6 commits into from
Feb 20, 2024
Merged

More changes to make dates and times consistent across dashboard #2306

merged 6 commits into from
Feb 20, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 19, 2024 •
edited
Loading

Fixes #2303

Make formatting consistent and respect user's 12/24 hour preference.

  • Chart ticks and tooltips shows 12/24 hour time
  • Chart period suffixes are localized
  • Trace detail date time is now consistent with other date times
  • Structured logs and traces timestamp now includes date if a different day
  • Resources start, structured logs timestamp, traces timestamp has a tooltip with date and time
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK mentioned this pull request Feb 19, 2024
Closed
@davidfowl
Copy link
Member

Pics?

@JamesNK
Copy link
Member Author

JamesNK commented Feb 19, 2024

Trace detail (now short date):
image

Metrics 12 hour (lowercase AM/PM based on user culture):
image

Metrics 24 hour (based on user culture):
image

@JamesNK JamesNK force-pushed the jamesnk/dashboard-date-consistency branch from c9cd456 to c743cc2 Compare February 19, 2024 13:22
drewnoakes
drewnoakes approved these changes Feb 20, 2024
View reviewed changes
src/Aspire.Dashboard/Utils/FormatHelpers.cs Outdated Show resolved Hide resolved
@JamesNK JamesNK enabled auto-merge (squash) February 20, 2024 00:47
@JamesNK JamesNK merged commit f4e9ea5 into main Feb 20, 2024
8 checks passed
@JamesNK JamesNK deleted the jamesnk/dashboard-date-consistency branch February 20, 2024 02:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

@tlmii tlmii Awaiting requested review from tlmii

@adamint adamint Awaiting requested review from adamint

@kvenkatrajan kvenkatrajan Awaiting requested review from kvenkatrajan

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time suggestions on the dashboard
3 participants
@JamesNK @davidfowl @drewnoakes