Don't try to cleanup DCP resources on shtudown #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
karolz-ms
approved these changes
Feb 20, 2024
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac (and probably Linux), the logic to try and cleanup orchestrator resources on shutdown causes more issues than it tries to solve; the resources aren't fully cleaned up by the time the delete request completes and it leaves several of the resources in a bad state such that the subsequent DCP cleanup logic can't fully remove them either and we only clean everything up after the one minute graceful shutdown timeout expires. This means it takes up to a minute for the child executables to be deleted.
Since DCP already has built in cleanup logic when the AppHost goes away (which is how resources get cleaned up when running in Visual Studio), there's no real reason for the AppHost to duplicate the effort.
Microsoft Reviewers: Open in CodeFlow